Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for xmlsec1 1.3
The feature or problem addressed by this PR
There are two changes in xmlsec1 1.3 that break compatibility for me:
I couldn't make it work without passing
--lax-key-search
to xmlsec1, 'cause in my case it seems like KeyInfo never contains the private key that is used for signature.Please let me know if you have a better solution.
What your changes do and why you chose this solution
I am checking the version of the xmlsec1 utility and if it is > 1.3, I am (a) adding the
--lax-key-search
param; (b) expect proper output during signature verification.Checklist