fix(combos): change valid property type to exposed IgxInputState #13646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previous type was `IgxComboState` but that was not exported from the public API and was also identical in values and somewhat redundant
damyanpetev
added
❌ status: awaiting-test
kdinev
previously approved these changes
Nov 8, 2023
kdinev
reviewed
Nov 8, 2023
CHANGELOG.md
Outdated
| @@ -28,6 +28,9 @@ All notable changes for each version of this project will be documented in this | |||
| - `ISimpleComboSelectionChangingEventArgs` exposes two new properties `newSelection` and `oldSelection` in place of the old ones that are no longer affected by `valueKey` and consistently emit items from Combo's `data`. | |||
|
|
|||
| Note: In remote data scenarios with `valueKey` set, selected items that are not currently part of the loaded data chunk will be emitted a partial item data object with the `valueKey` property. | |||
| - `IgxCombo`,`IgxSimpleCombo` | |||
There was a problem hiding this comment.
The changelog entry is not needed.
kdinev
approved these changes
Nov 8, 2023
kdinev
added
✅ status: verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous type was
IgxComboStatebut that was not exported from the public APIand was also identical in values and somewhat redundant, so just switched over to the existing
IgxInputStateit was using underneath anyway.Closes #
Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)