Skip to content

fix(igxGrid): The forbidden operation indicator is not shown when attempting to group by a column by which grouping is already performed. #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 5, 2018
Merged

fix(igxGrid): The forbidden operation indicator is not shown when attempting to group by a column by which grouping is already performed. #1900

merged 7 commits into from
Jul 5, 2018

Conversation

MayaKirova
Copy link
Contributor

Closes #1856.

fix(igxGrid): The forbidden operation indicator is not shown when att…
6f10009 
…empting to group by a column by which grouping is already performed.
@MayaKirova MayaKirova added the ❌ status: awaiting-test PRs awaiting manual verification label Jul 3, 2018
dkamburov
dkamburov previously approved these changes Jul 4, 2018
View reviewed changes
@mpavlinov mpavlinov changed the base branch from master to 6.1.x July 4, 2018 08:03
@MartinKamenov MartinKamenov added 💥 status: in-test PRs currently being tested and removed ❌ status: awaiting-test PRs awaiting manual verification labels Jul 4, 2018
ChronosSF
ChronosSF previously approved these changes Jul 4, 2018
View reviewed changes
@MayaKirova MayaKirova dismissed stale reviews from ChronosSF and dkamburov via e6936c1 July 4, 2018 11:43
@MartinKamenov MartinKamenov added ✅ status: verified Applies to PRs that have passed manual verification and removed 💥 status: in-test PRs currently being tested labels Jul 4, 2018
@kdinev kdinev merged commit 97d55d0 into 6.1.x Jul 5, 2018
@kdinev kdinev deleted the mkirova/fix-1856 branch July 5, 2018 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdinev kdinev kdinev approved these changes

@dkamburov dkamburov dkamburov left review comments

@ChronosSF ChronosSF ChronosSF left review comments

@mpavlinov mpavlinov Awaiting requested review from mpavlinov

Assignees

@MartinKamenov MartinKamenov

Labels
grid: general grid: groupby version: 6.1.x ✅ status: verified Applies to PRs that have passed manual verification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MayaKirova @dkamburov @kdinev @ChronosSF @mpavlinov @MartinKamenov @rkaraivanov