Update main.lua #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Caching the changed skill pre-event to increase the experience post-event. When doing it pre-event, the client adds the default spellcast experience afterwards, which is not saved on the server until GetSkillProgress is called, thus increasing the delta experience and increasing exponentially with each subsequent spellcast - Added a treshold to prevent rounding errors at the skillchange detection - Removed the ceil from the bonus experience, which gave a lot more bonus experience than intended
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing it pre-event, the client adds the default spellcast experience afterwards, which is not saved on the server until GetSkillProgress is called, thus increasing the delta experience and increasing exponentially with each subsequent spellcast