ConfigLoader : Specify encoding in calls to open()#1495
Merged
ericmehl merged 1 commit intoImageEngine:RB-10.6from Oct 13, 2025
Merged
ConfigLoader : Specify encoding in calls to open()#1495ericmehl merged 1 commit intoImageEngine:RB-10.6from
open()#1495ericmehl merged 1 commit intoImageEngine:RB-10.6from
Conversation
We did this in Gaffer back in GafferHQ/gaffer#5127, with the reasons being documented there. The lack of encoding in ConfigLoader was causing a similar problem when loading Gaffer config files in a Chinese/GBK locale.
ericmehl
approved these changes
Oct 13, 2025
Collaborator
ericmehl
left a comment
ericmehl
left a comment
There was a problem hiding this comment.
I haven't tested this with a different locale to exercise the problem, but it makes sense along with the Gaffer change noted above.
The user confirmed it fixed their problem and the code looks good. Giving it the stamp, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We did this in Gaffer back in GafferHQ/gaffer#5127, with the reasons being documented there. The lack of encoding in ConfigLoader was causing a similar problem when loading Gaffer config files in a Chinese/GBK locale.