SConstruct : Added INCLUDE_PATHS option and skip empty include paths#1497
Closed
ivanimanishi wants to merge 1 commit intoImageEngine:RB-10.6from
Closed
SConstruct : Added INCLUDE_PATHS option and skip empty include paths#1497ivanimanishi wants to merge 1 commit intoImageEngine:RB-10.6from
ivanimanishi wants to merge 1 commit intoImageEngine:RB-10.6from
Conversation
INCLUDE_PATHS is a list argument that can be used to add an arbitrary list of include paths to be added, with full control over their order from the options file. We are also avoiding adding any include paths that are empty, when using the old arguments. That is not strictly necessary (we could be setting it to an invalid path, for example) but does result in a much cleaner compile command.
Member
Author
|
Closed in favour of #1498, which should be a safer change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INCLUDE_PATHS is a list argument that can be used to add an arbitrary list of include paths to be added, with full control over their order from the options file.
We are also avoiding adding any include paths that are empty, when using the old arguments.
That is not strictly necessary (we could be setting it to an invalid path, for example) but does result in a much cleaner compile command.
Related Issues
We are changing our build environment at IE and want more control, from the options file, over which include paths are added to the compile commands and their order.
Checklist