Skip to content

Conversation

@viceroypenguin
Copy link
Member

No description provided.

@viceroypenguin viceroypenguin requested a review from Copilot August 27, 2025 02:04
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR converts the static-to-sealed handler refactoring from a code refactoring provider to a code fix provider, enabling "Fix All" functionality through analyzer integration.

Key changes:

  • Converts StaticToSealedHandlerRefactoringProvider to StaticToSealedHandlerCodeFixProvider
  • Adds new analyzer diagnostic IHR0019 for static handlers that could be sealed
  • Updates test infrastructure to use code fix testing instead of refactoring testing

Reviewed Changes

Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
StaticToSealedHandlerRefactoringProviderTests.cs Renamed class and converted tests from refactoring to code fix testing
CodeRefactoringTestHelper.cs Removed unused refactoring test helper
HandlerClassAnalyzer.cs Added new diagnostic IHR0019 for static handlers that could be sealed
StaticToSealedHandlerCodeFixProvider.cs Converted from refactoring provider to code fix provider with FixAll support
RefactoringExtensions.cs Updated extension methods for code fix context
DiagnosticIds.cs Added new diagnostic ID IHR0019
AnalyzerReleases.Shipped.md Added release notes for new diagnostic
Multiple test files Updated test expectations to include new IHR0019 diagnostic markers

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Aug 27, 2025

Codecov Report

❌ Patch coverage is 0% with 53 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
....CodeFixes/StaticToSealedHandlerCodeFixProvider.cs 0.00% 34 Missing ⚠️
...mediate.Handlers.Analyzers/HandlerClassAnalyzer.cs 0.00% 19 Missing ⚠️
Files with missing lines Coverage Δ
...mediate.Handlers.Analyzers/HandlerClassAnalyzer.cs 0.00% <0.00%> (ø)
....CodeFixes/StaticToSealedHandlerCodeFixProvider.cs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@viceroypenguin viceroypenguin merged commit 7432bad into master Aug 27, 2025
2 checks passed
@viceroypenguin viceroypenguin deleted the ihr0019 branch August 27, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants