Skip to content

improvement(dashboard): add secret tag/metadata search functionality to single env view dashboard #4199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025

Conversation

scott-ray-wilson
Copy link
Contributor

Description 📣

This PR updates the search functionality of the single env view secret dashboard to support tags and metadata

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@scott-ray-wilson scott-ray-wilson requested review from sheensantoscapadngan and x032205 and removed request for sheensantoscapadngan July 19, 2025 01:23
@maidul98
Copy link
Collaborator

maidul98 commented Jul 19, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR enhances the search functionality in the single environment view dashboard by adding support for searching through tags and metadata in addition to secret names. The changes span across multiple layers:

  1. Data layer (DTO types and DAL) updates to support new search filters
  2. Service layer implementation to handle tag and metadata searches
  3. Frontend updates to reflect the new search capabilities in the UI

Key architectural changes:

  • Added optional boolean flags includeTagsInSearch and includeMetadataInSearch to control search behavior
  • Enhanced SQL queries to search across multiple tables (secrets, tags, metadata) using ILIKE operators
  • Updated frontend placeholder text to indicate new search capabilities

The implementation maintains backward compatibility by making the new search parameters optional.

Confidence score: 4/5

  1. This PR is safe to merge as it adds non-breaking enhancements to existing search functionality
  2. High confidence due to consistent implementation across layers and proper SQL handling, but minor concerns about search performance with multiple ILIKE operations
  3. Files needing attention:
    • backend/src/services/secret-v2-bridge/secret-v2-bridge-dal.ts - Review SQL query performance
    • backend/src/server/routes/v1/dashboard-router.ts - Verify error handling for new search parameters

6 files reviewed, 1 comment
Edit PR Review Bot Settings | Greptile

Copy link
Contributor

@x032205 x032205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tag search works great, but not able to get metadata search to work. My secret is in base folder with a metadata entry two: three. Searching for two or three does nothing.

Copy link
Contributor

@x032205 x032205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scott-ray-wilson scott-ray-wilson merged commit a7041fc into main Jul 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants