Skip to content

Add Bitbucket Secret Sync #4210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 23, 2025
Merged

Add Bitbucket Secret Sync #4210

merged 5 commits into from
Jul 23, 2025

Conversation

carlosmonastyrski
Copy link
Contributor

Description 📣

Type ✨

  • Bug fix
  • New feature
  • Improvement
  • Breaking change
  • Documentation

Tests 🛠️

# Here's some code block to paste some code snippets

@maidul98
Copy link
Collaborator

maidul98 commented Jul 21, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Summary

This PR introduces Bitbucket secret synchronization functionality to Infisical, enabling users to sync secrets between Infisical and Bitbucket repositories. The implementation includes:

  • A complete integration pipeline with frontend components, backend services, and API documentation
  • Support for both repository-level and environment-specific variable synchronization
  • UI components for configuring Bitbucket syncs with workspace, repository, and optional environment selection
  • API endpoints for creating, updating, listing, and deleting Bitbucket secret syncs
  • Proper schema validation and type safety throughout the implementation

The implementation follows established patterns seen in existing integrations like GitHub and GitLab, maintaining consistency in the codebase while adding new functionality.

Confidence score: 3/5

  1. This PR adds significant new functionality but lacks certain safety measures.
  2. The score reflects concerns about pagination limits, regex usage in URLs, and potential security considerations in the Bitbucket API integration.
  3. Files needing attention:
    • backend/src/services/app-connection/bitbucket/bitbucket-connection-fns.ts: No pagination limits in listBitbucketEnvironments
    • backend/src/services/secret-sync/bitbucket/bitbucket-sync-fns.ts: URL encoding and API token handling
    • frontend/src/components/secret-syncs/forms/schemas/bitbucket-sync-destination-schema.ts: Input validation needs strengthening

47 files reviewed, 17 comments

Edit Code Review Bot Settings | Greptile

Copy link
Contributor

@x032205 x032205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything works great! Just some nits

Copy link
Contributor

@x032205 x032205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlosmonastyrski carlosmonastyrski merged commit b433582 into main Jul 23, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants