Skip to content

improvement: migrate update group modal to v3 components#7120

Merged
scott-ray-wilson merged 1 commit into
mainfrom
migrate-update-group-modal-to-v3
Jul 2, 2026
Merged

improvement: migrate update group modal to v3 components#7120
scott-ray-wilson merged 1 commit into
mainfrom
migrate-update-group-modal-to-v3

Conversation

@scott-ray-wilson

Copy link
Copy Markdown
Contributor

Context

This PR migrates the update group modal to v3 components

Screenshots

CleanShot 2026-07-01 at 14 40 53@2x

Steps to verify the change

Type

  • Fix
  • Feature
  • Improvement
  • Breaking
  • Docs
  • Chore

Checklist

  • Title follows the conventional commit format: type(scope): short description (scope is optional, e.g., fix: prevent crash on sync or fix(api): handle null response).
  • Tested locally
  • Updated docs (if needed)
  • Updated CLAUDE.md files (if needed)
  • Read the contributing guide

@infisical-review-police

Copy link
Copy Markdown

💬 Discussion in Slack: #pr-review-infisical-7120-improvement-migrate-update-group-modal-to-v3-components

Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel.

@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR migrates the GroupCreateUpdateModal from v2 component primitives (Modal, ModalContent, FormControl) to their v3 equivalents (Dialog, DialogContent, Field, FieldLabel, FieldError), and adds RoleOption as a custom renderer for the role FilterableSelect.

  • The dialog's onOpenChange handler now conditionally calls reset() only on close (if (!isOpen) reset()), fixing a pre-existing issue where resetting on open would briefly wipe pre-populated form values before the useEffect could repopulate them.
  • The isCreateMode flag is extracted as a named variable for cleaner conditional text rendering, and button order follows the standard v3 dialog pattern (Cancel first, Submit second).

Confidence Score: 5/5

Straightforward UI component migration with no logic changes to the underlying create/update API calls; safe to merge.

The change is a targeted swap of v2 dialog and form-control primitives for their v3 counterparts. The API mutation logic, form schema, and popup state management are all unchanged. The conditional reset() fix is a clear improvement. No new external inputs, network calls, or data-handling paths are introduced.

No files require special attention.

Important Files Changed

Filename Overview
frontend/src/pages/organization/GroupDetailsByIDPage/components/GroupCreateUpdateModal.tsx Migrates the group create/update modal from v2 (Modal/FormControl) to v3 (Dialog/Field) components; also fixes a pre-existing reset()-on-open bug and adds RoleOption for the role selector.

Reviews (1): Last reviewed commit: "improvement: migrate update group modal ..." | Re-trigger Greptile

@scott-ray-wilson scott-ray-wilson merged commit 1d84ae5 into main Jul 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants