refactor: Replace UserAvatar module with Avatar#445
Merged
Conversation
LunarX
force-pushed
the
replace-useravatar-with-avatar
branch
from
604f5f3 to
87341aa
Compare
sirambd
approved these changes
Jul 23, 2025
|
FabianDevel
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have a new more generic Avatar composable, we can quickly replace the only usage of UserAvatar that was in the MyKsuite module with the new Avatar module to avoid having to support deprecated code.
To avoid modifying the MyKsuite module too much, I copied the AvatarData data class inside of the MyKsuite module so the module can continue to use it and I simply turned it into the required AvatarType at the end.
For now, I did not delete the UserAvatar module because there's another branch which is not yet merged that started using UserAvatar and I would like to talk in perso with the person working on that branch