feat: Protect WebViewActivity to prevent open malicious url#724
Open
benjaminVadon wants to merge 2 commits intomainfrom
Open
feat: Protect WebViewActivity to prevent open malicious url#724benjaminVadon wants to merge 2 commits intomainfrom
benjaminVadon wants to merge 2 commits intomainfrom
Conversation
|
The changes implement a host whitelist to restrict URL loading, which is a good security improvement. However, the #ai-review-summary |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
WebView/src/main/kotlin/com/infomaniak/core/webview/ui/WebViewActivity.kt
Outdated
Show resolved
Hide resolved
WebView/src/main/kotlin/com/infomaniak/core/webview/ui/WebViewActivity.kt
Outdated
Show resolved
Hide resolved
WebView/src/main/kotlin/com/infomaniak/core/webview/ui/WebViewActivity.kt
Outdated
Show resolved
Hide resolved
benjaminVadon
force-pushed
the
protect-webview-with-host-whitelist
branch
from
f72af6c to
d2ca9f4
Compare
sirambd
requested changes
Mar 18, 2026
WebView/src/main/kotlin/com/infomaniak/core/webview/ui/WebViewActivity.kt
Outdated
Show resolved
Hide resolved
WebView/src/main/kotlin/com/infomaniak/core/webview/ui/WebViewActivity.kt
Outdated
Show resolved
Hide resolved
WebView/src/main/kotlin/com/infomaniak/core/webview/ui/WebViewActivity.kt
Outdated
Show resolved
Hide resolved
benjaminVadon
force-pushed
the
protect-webview-with-host-whitelist
branch
from
d2ca9f4 to
0f94e67
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.