fix: Update components to show files size and count of a transfer#293
Merged
valentinperignon merged 3 commits intomainfrom Dec 16, 2025
Merged
fix: Update components to show files size and count of a transfer#293valentinperignon merged 3 commits intomainfrom
valentinperignon merged 3 commits intomainfrom
Conversation
BaptGrv
force-pushed
the
fix/file-size-component
branch
from
cf74543 to
fd059a6
Compare
There was a problem hiding this comment.
Pull request overview
This PR refactors file count and size display components for transfer operations by introducing new specialized views. The changes aim to improve the separation of concerns between different display contexts (showing total size vs. showing remaining space).
- Created two new view components:
FilesCountAndSizeLeftViewfor displaying file count with space remaining validation, andSizeLeftViewfor displaying only remaining space - Simplified
FilesCountAndSizeViewto remove validation logic and error styling - Updated file list and cell views to use the new components with improved layout structure
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| SwissTransferFeatures/NewTransferView/NewTransferFilesCellView.swift | Updated to use FilesCountAndSizeLeftView instead of FilesCountAndSizeView |
| SwissTransferFeatures/NewTransferView/FilesCountAndSizeLeftView.swift | New component that displays file count and space left with validation and error styling |
| SwissTransferFeatures/NewTransferView/FileListView.swift | Refactored layout to use both FilesCountAndSizeView and new SizeLeftView in an HStack |
| SwissTransferCoreUI/Components/SizeLeftView.swift | New component that displays only the remaining transfer space |
| SwissTransferCoreUI/Components/FilesCountAndSizeView.swift | Simplified by removing validation logic, error colors, and space-left calculation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SwissTransferFeatures/NewTransferView/FilesCountAndSizeLeftView.swift
Outdated
Show resolved
Hide resolved
# Conflicts: # SwissTransferCoreUI/Components/FilesCountAndSizeView.swift # SwissTransferFeatures/NewTransferView/FileListView.swift
BaptGrv
force-pushed
the
fix/file-size-component
branch
from
fd059a6 to
c1dfa5a
Compare
BaptGrv
force-pushed
the
fix/file-size-component
branch
from
d9e6904 to
e3ca230
Compare
|
valentinperignon
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.