Merged
Conversation
PhilippeWeidmann
force-pushed
the
feat/2fa-notifications
branch
from
23f2f54 to
3b63571
Compare
PhilippeWeidmann
force-pushed
the
feat/2fa-notifications
branch
from
3b63571 to
f683d79
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR integrates push notification support for two-factor authentication (2FA) challenges into the Euria iOS app. The implementation adds the InfomaniakNotifications dependency and configures the app to receive and handle 2FA push notifications.
- Added
InfomaniakNotificationsdependency and configured it with the app group identifier - Implemented notification handling infrastructure with
AppDelegateandNotificationCenterDelegate - Integrated 2FA push notification topic registration at key points: account creation, app foreground, and initial setup
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Tuist/Package.swift | Added ios-notifications package dependency and changed InfomaniakConcurrency from static to dynamic framework |
| Tuist/Package.resolved | Updated package lock file with ios-notifications@15.1.0 and new origin hash |
| Project.swift | Added InfomaniakNotifications dependency to MainView, Euria, and EuriaCore targets |
| EuriaFeatures/MainView/MainView.swift | Added notification registration on foreground and stored session for API access |
| EuriaCore/Utils/TargetAssembly.swift | Registered InfomaniakNotifications service in DI container with app group identifier |
| EuriaCore/Extensions/Topic+Extension.swift | Defined twoFAPushChallenge topic constant for 2FA push notifications |
| EuriaCore/AccountManager.swift | Added notification topic subscription during account creation |
| Euria/Sources/NotificationCenterDelegate.swift | Implemented notification handling for 2FA challenges |
| Euria/Sources/EuriaApp.swift | Registered AppDelegate using UIApplicationDelegateAdaptor |
| Euria/Sources/AppDelegate.swift | Configured remote notifications and registered device tokens with backend |
| Euria/Resources/Euria.entitlements | Added development APS environment entitlement |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
PhilippeWeidmann
force-pushed
the
feat/2fa-notifications
branch
3 times, most recently
from
5476082 to
ebf065e
Compare
valentinperignon
force-pushed
the
feat/2fa-notifications
branch
from
8a7e95d to
7994bbd
Compare
PhilippeWeidmann
force-pushed
the
feat/2fa-notifications
branch
from
7994bbd to
5ee653f
Compare
valentinperignon
force-pushed
the
feat/2fa-notifications
branch
3 times, most recently
from
f62b84c to
27bfcb7
Compare
PhilippeWeidmann
force-pushed
the
feat/2fa-notifications
branch
3 times, most recently
from
d589e40 to
d3d825f
Compare
# Conflicts: # Euria/Sources/AppDelegate.swift # Euria/Sources/EuriaApp.swift # EuriaCore/Utils/TargetAssembly.swift # Project.swift # Tuist/Package.resolved
valentinperignon
force-pushed
the
feat/2fa-notifications
branch
from
d3d825f to
9ac062a
Compare
valentinperignon
approved these changes
Nov 12, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.