Skip to content

Feat: add argName to specify server arguments #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
InftyAI-Agent merged 2 commits into from
Jan 4, 2025
Merged

Feat: add argName to specify server arguments #226

InftyAI-Agent merged 2 commits into from
Jan 4, 2025

Conversation

@kerthcet
Copy link
Member

@kerthcet kerthcet commented Jan 4, 2025

What this PR does / why we need it

With this configuration, we can specify the arguments in playground, like:

  backendRuntimeConfig:
    name: llamacpp
    argName: foo

Which issue(s) this PR fixes

Fixes #

Special notes for your reviewer

Does this PR introduce a user-facing change?

None

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Jan 4, 2025
@kerthcet
Copy link
Member Author

kerthcet commented Jan 4, 2025

/kind feature
/approve

@InftyAI-Agent InftyAI-Agent added feature Categorizes issue or PR as related to a new feature. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Jan 4, 2025
@kerthcet
Remove gocyclo
b2aa243 
Signed-off-by: kerthcet <[email protected]>
@kerthcet
Copy link
Member Author

kerthcet commented Jan 4, 2025

/lgtm

@InftyAI-Agent InftyAI-Agent added the lgtm Looks good to me, indicates that a PR is ready to be merged. label Jan 4, 2025
@InftyAI-Agent InftyAI-Agent merged commit fa9ab40 into InftyAI:main Jan 4, 2025
14 checks passed
@kerthcet kerthcet deleted the feat/argument branch January 4, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kerthcet kerthcet

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kerthcet @InftyAI-Agent