Skip to content

Conversation

@googs1025
Copy link
Member

What this PR does / why we need it

/kind cleanup
/kind api-change

  • fix BackendRuntime crds field Commands -> Command

Which issue(s) this PR fixes

Fixes #309

Special notes for your reviewer

Does this PR introduce a user-facing change?


@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 13, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet March 13, 2025 11:44
@googs1025
Copy link
Member Author

/kind cleanup
/kind api-change

@InftyAI-Agent InftyAI-Agent added cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. api-change Indicates PR includes api change. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Mar 13, 2025
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the backendRuntime in helm charts as well. They can not be auto-generated.

@googs1025
Copy link
Member Author

helm chart is a stable version that has been released. do we need to change ?

@kerthcet
Copy link
Member

helm chart will be autogenerated by make helm-package command on release, but backendRuntime configuration will not be updated the same time, they're managed by hand, if we don't update them the same time, we may forget it.

Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more comments left.

Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one nit.

index.yaml Outdated
- https://inftyai.github.io/llmaz/llmaz-0.0.1.tgz
version: 0.0.1
generated: "2025-02-18T14:46:30.460221+08:00"
generated: "2025-02-18T14:46:30.460221+08:00"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this as well, the index.yaml should only be updated when release a new helm chart.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: googs1025 <[email protected]>
@kerthcet
Copy link
Member

/lgtm
/approve
Thanks @googs1025

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 14, 2025
@InftyAI-Agent InftyAI-Agent merged commit 568e6e4 into InftyAI:main Mar 14, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api-change Indicates PR includes api change. approved Indicates a PR has been approved by an approver from all required OWNERS files. cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

confusion about commands in backruntime

3 participants