-
-
Notifications
You must be signed in to change notification settings - Fork 44
chore: fix BackendRuntime crds field Commands -> Command #315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/kind cleanup |
kerthcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you fix the backendRuntime in helm charts as well. They can not be auto-generated.
|
helm chart is a stable version that has been released. do we need to change ? |
|
helm chart will be autogenerated by |
kerthcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more comments left.
kerthcet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one nit.
index.yaml
Outdated
| - https://inftyai.github.io/llmaz/llmaz-0.0.1.tgz | ||
| version: 0.0.1 | ||
| generated: "2025-02-18T14:46:30.460221+08:00" | ||
| generated: "2025-02-18T14:46:30.460221+08:00" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this as well, the index.yaml should only be updated when release a new helm chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
9768f91 to
141fd10
Compare
Signed-off-by: googs1025 <[email protected]>
141fd10 to
70c3dd0
Compare
|
/lgtm |
What this PR does / why we need it
/kind cleanup
/kind api-change
Which issue(s) this PR fixes
Fixes #309
Special notes for your reviewer
Does this PR introduce a user-facing change?