add image repo for lws and all backend runtime, like llama.cpp #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InftyAI-Agent
added
needs-triage
Member
|
This makes the configuration more flexible! |
Member
|
/lgtm Thanks! |
InftyAI-Agent
added
lgtm
googs1025
reviewed
Apr 17, 2025
| command: | ||
| - /manager | ||
| image: registry.k8s.io/lws/lws:v0.5.0 | ||
| image: {{ .Values.backendRuntime.image.repository }}:{{ .Values.backendRuntime.image.tag }} |
Member
There was a problem hiding this comment.
I see that this part of the helm chart has been rolled back. Is this an missing or do we not want users to config freely during installation of lws by default? 🤔 @kerthcet
Member
There was a problem hiding this comment.
First of all, this part is not right, because we should use les config, secondly update the image is not enough, because we may need to upgrade the crd as well. So if we want to upgrade lws, let's follow lws upgradation steps.
Member
There was a problem hiding this comment.
Thanks for the reply! That makes a lot of sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
need to update the images for my env
Which issue(s) this PR fixes
Fixes None
Special notes for your reviewer
Does this PR introduce a user-facing change?