Skip to content

Conversation

@pacoxu
Copy link
Contributor

@pacoxu pacoxu commented Apr 22, 2025

What this PR does / why we need it

Which issue(s) this PR fixes

Fixes #339

Special notes for your reviewer

Does this PR introduce a user-facing change?

Add Envoy AI Gateway Initiative 

@InftyAI-Agent InftyAI-Agent added needs-triage Indicates an issue or PR lacks a label and requires one. needs-priority Indicates a PR lacks a label and requires one. do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Apr 22, 2025
@InftyAI-Agent InftyAI-Agent requested a review from kerthcet April 22, 2025 07:01
@pacoxu
Copy link
Contributor Author

pacoxu commented Apr 22, 2025

/kind feature

@InftyAI-Agent InftyAI-Agent added feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-kind Indicates a PR lacks a label and requires one. labels Apr 22, 2025
@pacoxu pacoxu mentioned this pull request Apr 22, 2025

### 1. Enable Envoy Gateway and Envoy AI Gateway in llmaz Helm

Enable Envoy Gateway and Envoy AI Gateway in the `values.global.yaml` file, envoy gateway and envoy ai gateway are disabled by default.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can add link to values.global.yaml?

Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM.

@pacoxu pacoxu force-pushed the add-enovy-ai-gateway branch from 25cef6c to 912f044 Compare April 22, 2025 07:50
Copy link
Member

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit. I'll update the README.md as a follow up.

@pacoxu pacoxu force-pushed the add-enovy-ai-gateway branch from 912f044 to a2fcf2c Compare April 22, 2025 08:04
@kerthcet
Copy link
Member

/lgtm
/approve

Thanks! Great work!

@InftyAI-Agent InftyAI-Agent added lgtm Looks good to me, indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 22, 2025
@InftyAI-Agent InftyAI-Agent merged commit 846cb80 into InftyAI:main Apr 22, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. feature Categorizes issue or PR as related to a new feature. lgtm Looks good to me, indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a label and requires one. needs-triage Indicates an issue or PR lacks a label and requires one.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Envoy Gateway Initial

4 participants