Skip to content

Add custom JP book cover #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2022
Merged

Add custom JP book cover #432

merged 2 commits into from
Jul 29, 2022

Conversation

spier
Copy link
Member

@spier spier commented Jul 29, 2022

Add JP book cover. Move book covers to language folders.
Part of #430

Also made one tiny formatting fix.

@spier spier added (Self-) Hosting Everything around artifact rendering and presentation. Type - Translation Translating patterns into other languages labels Jul 29, 2022
@spier spier requested a review from yuhattor as a code owner July 29, 2022 10:40
@spier
Copy link
Member Author

spier commented Jul 29, 2022

Nice! This PR got auto-assigned to @yuhattor due to the CODEOWNERS specs.

As I already discussed the cover with Yuki in Slack, I will merge without further review.

@spier spier merged commit e888917 into main Jul 29, 2022
@spier spier deleted the add-jp-book-cover branch July 29, 2022 10:44
@yuhattor
Copy link
Member

yuhattor commented Aug 2, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Self-) Hosting Everything around artifact rendering and presentation. Type - Translation Translating patterns into other languages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants