Use glob to select files to be checked by vale #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 603a7c3.
|
Reminder to self that while the vale GHA currently runs on most PRs, it doesn't output the information as we might expect see here:
I recall that in this PR here I was trying to make things work better but not sure how far I got. |
spier
changed the title
spier
added
the
Type - Maintenance / Cleanup
spier
requested review from
lenucksi,
NewMexicoKid,
cewilliams and
robtuley
as code owners
rmarting
pushed a commit
to rmarting/InnerSourcePatterns
that referenced
this pull request
Feb 29, 2024
* Use glob to select files to be checked by vale * Removing GH token * Remove unused gitignore rule * Adding debug flag, to increase inspectability of vale output in future GHA runs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output of the vale spell/style checks is not shown in the PR as expected.
Therefore I am running some experiments here to fix this.