feat: support masking screen names #500
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a7medev
force-pushed
the
feat/mask-screen-names
branch
from
7a5c6df to
6181dcf
Compare
a7medev
force-pushed
the
feat/mask-screen-names
branch
from
68eb671 to
ebfb74b
Compare
a7medev
commented
Aug 12, 2024
| routePath: trace.screenName, | ||
| actualPath: currentUiTrace?.screenName, | ||
| ); | ||
| final isSameScreen = currentUiTrace?.matches(trace.screenName) == true; |
There was a problem hiding this comment.
Replaced the direct RouteMatcher call with UiTrace.matches as the matching screen name is not exposed on the UiTrace object to avoid misuse.
AndrewAminInstabug
approved these changes
Aug 13, 2024
ahmedAlaaInstabug
approved these changes
Aug 13, 2024
ahmedAlaaInstabug
pushed a commit
that referenced
this pull request
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Support masking screen names using
Instabug.setScreenNameMaskingCallback.Type of change
Related issues
Jira ID: MOB-15531
Checklists
Development
Code review