Skip to content

fix(ios): update native network logging method signature #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

a7medev
Copy link
Contributor

@a7medev a7medev commented Sep 10, 2024

Description of the change

Update the network logging API signature used to match the one updated in v13.4.0 of the iOS SDK.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Jira ID: MOB-15866

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

@a7medev a7medev self-assigned this Sep 10, 2024
@a7medev a7medev changed the base branch from master to release/13.4.0 September 10, 2024 13:32
@InstabugCI
Copy link
Collaborator

Coverage Report

Label Coverage Status
Dart 85.3%

Generated by 🚫 dangerJS against 0e8388b

@a7medev a7medev merged commit 5e22ff7 into release/13.4.0 Sep 11, 2024
11 checks passed
@a7medev a7medev deleted the fix/ios-network-log-api branch September 11, 2024 13:26
ahmedAlaaInstabug added a commit that referenced this pull request Sep 13, 2024
* chore(ios): bump sdk to v13.4.0

* chore(android): bump sdk to v13.4.0

* chore: bump sdk version to v13.4.0

* chore: update changelog

* fix(ios): update native network logging method signature (#507)

* fix(ios): update native network logging method signature

* feat(example): add network logging in example

---------

Co-authored-by: Ahmed alaa <[email protected]>
ahmedAlaaInstabug added a commit that referenced this pull request Nov 4, 2024
* chore(ios): bump sdk to v13.4.0

* chore(android): bump sdk to v13.4.0

* chore: bump sdk version to v13.4.0

* chore: update changelog

* fix(ios): update native network logging method signature (#507)

* fix(ios): update native network logging method signature

* feat(example): add network logging in example

---------

Co-authored-by: Ahmed alaa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants