Skip to content

Refactor: merge private-views package into mono-repo #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 45 commits into from
Jan 8, 2025
Merged

Refactor: merge private-views package into mono-repo #527

merged 45 commits into from
Jan 8, 2025

Conversation

ahmedAlaaInstabug
Copy link
Contributor

Description of the change

  1. merge private-views package into mono-repo

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

JIRA ID : MOB-16296

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests

Code review

  • This pull request has a descriptive title and information useful to a reviewer
  • Issue from task tracker has a link to this pull request

ahmedAlaaInstabug and others added 23 commits October 2, 2024 23:14
@ahmedAlaaInstabug
feat: add private view
e0c0fd2
@ahmedAlaaInstabug
feat: add private view
c38dead
@ahmedAlaaInstabug
Merge remote-tracking branch 'refs/remotes/origin/dev' into feat/priv…
23d3912 
…ate-views

# Conflicts:
#	CHANGELOG.md
@ahmedAlaaInstabug
feat: add private view
1af3598
@ahmedAlaaInstabug
feat: add private view
0476bcd
@ahmedAlaaInstabug
feat: add private view
9b8ec64
@ahmedAlaaInstabug
feat: add private view
cedc297
@ahmedAlaaInstabug
feat: add private view
59c1ffa
@ahmedAlaaInstabug
feat: add private view android integration
f7f8f08
@ahmedAlaaInstabug
feat: add private view android integration
c9bb481
@ahmedAlaaInstabug
feat: add private view android integration
52bced3
@ahmedAlaaInstabug
fix PR comments
d0f334f
@ahmedAlaaInstabug
fix: android test cases
ae524a2
@ahmedAlaaInstabug
fix: android test cases
ddead7f
@ahmedAlaaInstabug
fix PR comments
7414132
@ahmedAlaaInstabug
doc:comment why not use const constructor
476c29e
@ahmedAlaaInstabug
feat(ios): handle private views (#524)
5b94581
@ahmedAlaaInstabug
feat: add private view example page (#525)
6dcdffb 
* feat: add private view page

* fix private view screen
@ahmedAlaaInstabug
init
a142b7b
@ahmedAlaaInstabug
Merge branch 'refs/heads/refactor/monorepo' into refactor/monorepo-pr…
92201a1 
…ivate-view-package

# Conflicts:
#	packages/instabug_flutter/example/.gitignore
#	packages/instabug_flutter/example/pubspec.yaml
@ahmedAlaaInstabug
init
422e21f
@ahmedAlaaInstabug
init
53abf96
@ahmedAlaaInstabug
init
c8b944d
@InstabugCI
Copy link
Collaborator

InstabugCI commented Nov 2, 2024 •
edited
Loading

Warnings
⚠️

Coverage for instabug_http_client is less than the expected threshold of 80%
⚠️

Coverage for instabug_private_views is less than the expected threshold of 80%

Coverage Report

Label Coverage Status
instabug_dio_interceptor 92.5% ✅
instabug_flutter 80.4% ✅
instabug_flutter_modular 91.2% ✅
instabug_http_client 70.0% ❌
instabug_private_views 73.6% ❌

Generated by 🚫 dangerJS against 05fac1f

@ahmedAlaaInstabug ahmedAlaaInstabug self-assigned this Nov 3, 2024
@ahmedAlaaInstabug ahmedAlaaInstabug requested review from AndrewAminInstabug and a7medev and removed request for AndrewAminInstabug November 3, 2024 23:20
@ahmedAlaaInstabug ahmedAlaaInstabug marked this pull request as ready for review November 3, 2024 23:21
@ahmedAlaaInstabug ahmedAlaaInstabug force-pushed the refactor/monorepo-private-view-package branch from a6e58fc to 38971ab Compare November 10, 2024 15:01
@ahmedAlaaInstabug
add hybrid app
837e133
@ahmedAlaaInstabug
add hybrid app
d157d4e
@ahmedAlaaInstabug
add hybrid app
e9d124a
@ahmedAlaaInstabug
add more example in private view oage
a6789c2
@ahmedAlaaInstabug
add more example in private view oage
0370666
@ahmedAlaaInstabug
add more example in private view oage
5f0af4c
@ahmedAlaaInstabug
chore: add build files
4dcf75f
@ahmedAlaaInstabug
chore: add animation
e4b6c3a
@ahmedAlaaInstabug
fix: private view time
89d0de1
@ahmedAlaaInstabug
fix: private view time
7763743
@ahmedAlaaInstabug
Merge remote-tracking branch 'refs/remotes/origin/refactor/monorepo' …
dc50a5c 
…into refactor/monorepo-private-view-package

# Conflicts:
#	packages/instabug_flutter/android/build.gradle
#	packages/instabug_flutter/android/src/main/java/com/instabug/flutter/modules/InstabugApi.java
#	packages/instabug_flutter/android/src/test/java/com/instabug/flutter/InstabugApiTest.java
#	packages/instabug_flutter/example/ios/Podfile.lock
#	packages/instabug_flutter/ios/Classes/Modules/InstabugApi.m
#	scripts/init.sh
@ahmedAlaaInstabug
chore: update to latest version
838a434
@ahmedAlaaInstabug
chore: update to latest version
86ba310
@ahmedAlaaInstabug
chore: update to latest version
48b1132
@ahmedAlaaInstabug
Merge remote-tracking branch 'refs/remotes/origin/refactor/monorepo-p…
c50bc61 
…rivate-view-package-test' into refactor/monorepo-private-view-package

# Conflicts:
#	packages/instabug_private_views/lib/src/instabug_private_view.dart
@ahmedAlaaInstabug
chore: update to latest version
cdb8017
@ahmedAlaaInstabug
chore: update to latest version
2215874
@ahmedAlaaInstabug
chore: update to latest version
be76a07
@ahmedAlaaInstabug
Merge branch 'refs/heads/refactor/monorepo' into refactor/monorepo-pr…
4ac9541 
…ivate-view-package

# Conflicts:
#	.circleci/config.yml
@ahmedAlaaInstabug
monorepo
05fac1f
@ahmedAlaaInstabug ahmedAlaaInstabug merged commit 49ea245 into refactor/monorepo Jan 8, 2025
6 of 11 checks passed
@ahmedAlaaInstabug ahmedAlaaInstabug deleted the refactor/monorepo-private-view-package branch January 8, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewAminInstabug AndrewAminInstabug AndrewAminInstabug approved these changes

@a7medev a7medev Awaiting requested review from a7medev

@kholood-ea kholood-ea Awaiting requested review from kholood-ea

@AyaMahmoud148 AyaMahmoud148 Awaiting requested review from AyaMahmoud148

Assignees

@ahmedAlaaInstabug ahmedAlaaInstabug

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahmedAlaaInstabug @InstabugCI @AndrewAminInstabug