ScheduledMerges: make the size ratio configurable
#717
+71
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
force-pushed
the
jdral/prototypes-configurable-writebuffersize
branch
from
8c8c7ee to
ffc0607
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-sizeratio
branch
from
bb3a72e to
d685bcc
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-writebuffersize
branch
2 times, most recently
from
5244165 to
32aa054
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-sizeratio
branch
from
d685bcc to
a4063c0
Compare
jorisdral
requested review from
dcoutts,
mheinzel,
recursion-ninja and
wenkokke
as code owners
jorisdral
force-pushed
the
jdral/prototypes-configurable-sizeratio
branch
from
a4063c0 to
00b9aec
Compare
|
I've put the PR back into draft mode because I found a bug |
jorisdral
force-pushed
the
jdral/prototypes-configurable-writebuffersize
branch
4 times, most recently
from
2b67d45 to
44a8197
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-sizeratio
branch
from
00b9aec to
beb5afe
Compare
|
Ready for review again! |
jorisdral
force-pushed
the
jdral/prototypes-configurable-writebuffersize
branch
from
44a8197 to
ad1e471
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-sizeratio
branch
from
beb5afe to
9dde4c3
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-writebuffersize
branch
from
ad1e471 to
18063cb
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-sizeratio
branch
from
9dde4c3 to
c3bf08d
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-writebuffersize
branch
from
18063cb to
c0e13ef
Compare
jorisdral
force-pushed
the
jdral/prototypes-configurable-sizeratio
branch
from
c3bf08d to
1f5611d
Compare
Base automatically changed from
jdral/prototypes-configurable-writebuffersize
to
main
May 21, 2025 14:27
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's probably also a prerequisite to prototype the merge schedule with size ratios other than
4before we can be confident that we can make it configurable in the real implementation too.At that point, we'd need to configure the size ratio in the
ScheduledMergesprototype if we want to compare traces for the prototype and real implementation (see #445).This PR builds on top of #716 to reduce the number of merge conflicts