Skip to content

App/update expo #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions native/app.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ const config = () => ({
cameraPermission: "Pozwól $(PRODUCT_NAME) na dostęp do kamery.",
},
],
["expo-font"],
],
extra: {
eas: {
Expand Down
15 changes: 1 addition & 14 deletions native/babel.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,6 @@ module.exports = function (api) {
api.cache(true);
return {
presets: ["babel-preset-expo"],
plugins: [
[
"module:react-native-dotenv",
{
moduleName: "@env",
path: ".env",
blacklist: null,
whitelist: null,
safe: false,
allowUndefined: true,
},
],
"react-native-reanimated/plugin",
],
plugins: ["react-native-reanimated/plugin"],
};
};
6 changes: 3 additions & 3 deletions native/components/BarcodeScanner/index.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { useNavigation } from "@react-navigation/native";
import { BarCodeScanningResult, Camera as ExpoCamera } from "expo-camera";
import { BarcodeScanningResult, CameraView as ExpoCamera } from "expo-camera";
import React, { useRef, useState } from "react";
import { Alert, StyleSheet, View } from "react-native";
import { useListBarcodes } from "../../db/hooks/useListBarcodes";
Expand Down Expand Up @@ -30,7 +30,7 @@ export const BarcodeScanner = ({
);
}

const handleBarcodeScan = (event: BarCodeScanningResult) => {
const handleBarcodeScan = (event: BarcodeScanningResult) => {
const { data } = event;
const barcodeMappedToId = barcodeList?.[data];
if (!barcodeMappedToId) {
Expand Down Expand Up @@ -71,7 +71,7 @@ export const BarcodeScanner = ({
return (
<Camera
ref={cameraRef}
onBarCodeScanned={handleBarcodeScan}
onBarcodeScanned={handleBarcodeScan}
shouldShowScannerOverlay
shouldAllowCameraToggle
/>
Expand Down
77 changes: 11 additions & 66 deletions native/components/Camera.tsx
Original file line number Diff line number Diff line change
@@ -1,12 +1,6 @@
import { AutoFocus, CameraType, Camera as ExpoCamera } from "expo-camera";
import { CameraType, CameraView as ExpoCamera } from "expo-camera";

import React, {
ComponentProps,
RefObject,
forwardRef,
useEffect,
useState,
} from "react";
import React, { ComponentProps, forwardRef, useEffect, useState } from "react";
import {
Alert,
Image,
Expand All @@ -21,12 +15,11 @@ import { isIos } from "../constants";
import { appAction, appSelector } from "../redux/appSlice";
import { useAppDispatch, useAppSelector } from "../redux/hooks";
import { createStyles } from "../theme/useStyles";
import { getBestCameraRatio } from "../utils";
import { CameraSwitchIcon, InfoIcon } from "./Icon";
import { LoadingSpinner } from "./LoadingSpinner";

type CameraProps = {
onBarCodeScanned?: ComponentProps<typeof ExpoCamera>["onBarCodeScanned"];
onBarcodeScanned?: ComponentProps<typeof ExpoCamera>["onBarcodeScanned"];
onTakePhoto?: () => void | Promise<void>;
shouldShowTakePhotoButton?: boolean;
shouldAllowCameraToggle?: boolean;
Expand Down Expand Up @@ -58,7 +51,7 @@ const askToOpenInfoPage = () => {
export const Camera = forwardRef<ExpoCamera, CameraProps>(
(
{
onBarCodeScanned,
onBarcodeScanned,
onTakePhoto,
shouldShowTakePhotoButton = false,
shouldAllowCameraToggle = false,
Expand All @@ -70,87 +63,39 @@ export const Camera = forwardRef<ExpoCamera, CameraProps>(
const styles = useStyles();

const isCameraReady = useAppSelector(appSelector.selectIsCameraReady);
const ratio = useAppSelector(appSelector.selectCameraRatio);
const dispatch = useAppDispatch();

const [type, setType] = useState(CameraType.back);

// workaround to trigger refocuses on ios
const [autoFocus, setAutoFocus] = useState(AutoFocus.on);
const timeout = setTimeout(() => setAutoFocus(AutoFocus.on), 50);
const updateCameraFocus = () => {
setAutoFocus(() => AutoFocus.off);
};

useEffect(() => {
return () => clearTimeout(timeout);
}, []);
const [facing, setFacing] = useState<CameraType>("back");

useEffect(() => {
return () => {
dispatch(appAction.SET_IS_CAMERA_READY({ isCameraReady: false }));
};
}, []);

useEffect(() => {
// ratio needed on android only
if (cameraRef == null) {
console.error("Camera - cameraRef is missing! This should not happen.");
return;
}
if (ratio || !isCameraReady || isIos) {
return;
}
const getCameraRatio = async () => {
try {
const ratios = await (
cameraRef as RefObject<ExpoCamera>
).current?.getSupportedRatiosAsync();
const ratio = getBestCameraRatio(ratios ?? null);
dispatch(appAction.SET_CAMERA_RATIO({ cameraRatio: ratio }));
} catch (error) {
console.log(error);
}
};

getCameraRatio();
}, [isCameraReady, ratio, cameraRef, dispatch]);

const toggleCameraType = () => {
setType((current) =>
current === CameraType.back ? CameraType.front : CameraType.back
);
setFacing((current) => (current === "back" ? "front" : "back"));
};

const doubleTap = Gesture.Tap().numberOfTaps(2).onStart(toggleCameraType);
const singleTap = Gesture.Tap().onStart(updateCameraFocus);

const composedGestures = shouldAllowCameraToggle
? Gesture.Exclusive(doubleTap, singleTap)
: singleTap;

return (
<GestureDetector gesture={composedGestures}>
<GestureDetector gesture={doubleTap}>
<View style={styles.container}>
{(isIos ? !isCameraReady : !isCameraReady || ratio == null) && (
<LoadingSpinner size="large" />
)}
{!isCameraReady && <LoadingSpinner size="large" />}
<ExpoCamera
ref={cameraRef}
style={[
(isIos ? !isCameraReady : !isCameraReady || ratio == null) && {
(isIos ? !isCameraReady : !isCameraReady) && {
display: "none",
},
styles.camera,
]}
// not displayed if null, as specified above
ratio={ratio!}
onCameraReady={() =>
dispatch(appAction.SET_IS_CAMERA_READY({ isCameraReady: true }))
}
type={type}
onBarCodeScanned={onBarCodeScanned}
autoFocus={autoFocus}
facing={facing}
onBarcodeScanned={onBarcodeScanned}
>
{shouldShowInfoPageIcon || shouldAllowCameraToggle ? (
<View style={styles.cameraFloatersContainer}>
Expand Down
6 changes: 3 additions & 3 deletions native/components/DocumentScanner/index.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Camera as ExpoCamera, ImageType } from "expo-camera";
import { CameraView as ExpoCamera } from "expo-camera";

import React, { useRef } from "react";
import {
Expand Down Expand Up @@ -32,8 +32,8 @@ export const DocumentScanner = ({
const photo = await cameraRef.current.takePictureAsync({
exif: false,
base64: true,
quality: 0.8,
imageType: ImageType.jpg,
quality: 0.6,
imageType: "jpg",
});
dispatch(documentScannerAction.PHOTO_TAKE({ photo }));
dispatch(documentScannerAction.SWITCH_PREVIEW());
Expand Down
Loading