Prevent monitor to froze..#104
Merged
Merged
Conversation
In the debouncer thread, debounce_at stores the instant when accumulated events should be flushed. The outer match checks debounce_at.checked_duration_since(Instant::now()) — but when the debounce period expires, checked_duration_since returns None, landing in the None arm even though debounce_at is still Some(past_time). The inner guard if debounce_at.is_none() then silently dropped all incoming events and never flushed the pending ones. The monitor appeared alive but effectively froze.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the debouncer thread, debounce_at stores the instant when accumulated events should be flushed. The outer match checks debounce_at.checked_duration_since(Instant::now()) — but when the debounce period expires, checked_duration_since returns None, landing in the None arm even though debounce_at is still Some(past_time). The inner guard if debounce_at.is_none() then silently dropped all incoming events and never flushed the pending ones. The monitor appeared alive but effectively froze.