Skip to content

Conversation

pierreguillot
Copy link
Contributor

@pierreguillot pierreguillot commented Sep 12, 2025

close #175
close #184

@pierreguillot pierreguillot added this to the 2.1.1 milestone Sep 12, 2025
@pierreguillot pierreguillot self-assigned this Sep 12, 2025
@pierreguillot pierreguillot added the enhancement New feature or request label Sep 12, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds an option to configure the rendering of grid graduations and labels outside the frame when exporting images. The implementation allows users to specify which borders (left, right, top, bottom) should display grid ticks and labels externally to the main plot area.

Key changes include:

  • Modified rendering functions to accept an outsideGridJustification parameter that controls external grid placement
  • Added UI controls in the export panel to configure outside grid positioning
  • Updated image export functions to account for additional border space when outside grids are enabled

Reviewed Changes

Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Source/Track/AnlTrackRenderer.h Added new function parameter and helper function declarations for outside grid rendering
Source/Track/AnlTrackRenderer.cpp Implemented outside grid rendering logic and refactored internal grid painting
Source/Track/AnlTrackPlot.cpp Updated paint call to pass none justification for normal plot rendering
Source/Track/AnlTrackExporter.h Added outsideGridJustification parameter to image export functions
Source/Track/AnlTrackExporter.cpp Updated image export implementation to use outside grid justification
Source/Group/AnlGroupPlot.cpp Updated group plot rendering to pass none justification
Source/Group/AnlGroupExporter.h Added outsideGridJustification parameter to group export functions
Source/Group/AnlGroupExporter.cpp Updated group export implementation with outside grid support
Source/Document/AnlDocumentExporter.h Added outside grid justification option and updated helper functions
Source/Document/AnlDocumentExporter.cpp Comprehensive updates to export panel UI and image dimension calculations
Docs/Partiels-Manual.md Updated documentation to describe the new outside grid feature
Dependencies/Misc/Source/Zoom/MiscZoomGrid.h Added custom Justification class to replace JUCE's justification
Dependencies/Misc/Source/Zoom/MiscZoomGrid.cpp Updated grid painting to use custom justification flags
Dependencies/Misc/Source/MiscPropertyComponent.h Added VariableComboBox class for custom popup behavior
Dependencies/Misc/Source/MiscPropertyComponent.cpp Implemented VariableComboBox with custom popup handling

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

Source/Document/AnlDocumentExporter.cpp:1

  • The parameter name should be consistent across all functions. This uses outsideGridJustification while the header uses outsideGridjustification (lowercase 'j').
#include "AnlDocumentExporter.h"

@pierreguillot pierreguillot merged commit 1fb4dc1 into main Sep 12, 2025
16 checks passed
@pierreguillot pierreguillot deleted the dev/export-outside-grid branch September 12, 2025 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing the font of a track changes the font of the grid Add an option to display grid ticks outside the frame when exporting images
1 participant