-
Notifications
You must be signed in to change notification settings - Fork 2
Add an option to configure the rendering of grid graduations and labels outside the frame when exporting images #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds an option to configure the rendering of grid graduations and labels outside the frame when exporting images. The implementation allows users to specify which borders (left, right, top, bottom) should display grid ticks and labels externally to the main plot area.
Key changes include:
- Modified rendering functions to accept an
outsideGridJustification
parameter that controls external grid placement - Added UI controls in the export panel to configure outside grid positioning
- Updated image export functions to account for additional border space when outside grids are enabled
Reviewed Changes
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
Source/Track/AnlTrackRenderer.h | Added new function parameter and helper function declarations for outside grid rendering |
Source/Track/AnlTrackRenderer.cpp | Implemented outside grid rendering logic and refactored internal grid painting |
Source/Track/AnlTrackPlot.cpp | Updated paint call to pass none justification for normal plot rendering |
Source/Track/AnlTrackExporter.h | Added outsideGridJustification parameter to image export functions |
Source/Track/AnlTrackExporter.cpp | Updated image export implementation to use outside grid justification |
Source/Group/AnlGroupPlot.cpp | Updated group plot rendering to pass none justification |
Source/Group/AnlGroupExporter.h | Added outsideGridJustification parameter to group export functions |
Source/Group/AnlGroupExporter.cpp | Updated group export implementation with outside grid support |
Source/Document/AnlDocumentExporter.h | Added outside grid justification option and updated helper functions |
Source/Document/AnlDocumentExporter.cpp | Comprehensive updates to export panel UI and image dimension calculations |
Docs/Partiels-Manual.md | Updated documentation to describe the new outside grid feature |
Dependencies/Misc/Source/Zoom/MiscZoomGrid.h | Added custom Justification class to replace JUCE's justification |
Dependencies/Misc/Source/Zoom/MiscZoomGrid.cpp | Updated grid painting to use custom justification flags |
Dependencies/Misc/Source/MiscPropertyComponent.h | Added VariableComboBox class for custom popup behavior |
Dependencies/Misc/Source/MiscPropertyComponent.cpp | Implemented VariableComboBox with custom popup handling |
0f45cf6
to
7ae8f2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 15 out of 17 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
Source/Document/AnlDocumentExporter.cpp:1
- The parameter name should be consistent across all functions. This uses
outsideGridJustification
while the header usesoutsideGridjustification
(lowercase 'j').
#include "AnlDocumentExporter.h"
close #175
close #184