Open
Conversation
Update Router.d.ts type for svelte5
- Remove on:routeEvent from component template (no longer supported in Svelte 5) - Add event callback props (onconditionsFailed, onrouteLoading, onrouteLoaded) - Update dispatchNextTick to call both dispatcher and callback props - Update TypeScript definitions for Svelte 5 component model - Update package.json version to 5.0.0 and description for Svelte 5 - Update README and Advanced Usage docs for Svelte 5 syntax - Add MIGRATION_SVELTE5.md guide for users upgrading from Svelte 4 Breaking changes: - Event handlers now use prop syntax (onconditionsFailed vs on:conditionsFailed) - routeEvent mechanism removed (use callback props or stores instead)
Renamed local 'props' variable to 'componentProps' to avoid conflict with RouteItem.props property, which was causing 'can't access lexical declaration before initialization' error in Svelte 5.
Convert component, componentParams, componentProps, previousScrollState, lastLoc, and componentObj to use $state rune for proper reactivity in Svelte 5.
Remove $state from lastLoc and componentObj as they are used for comparisons with non-state values and don't need to be reactive. This fixes the state_proxy_equality_mismatch warnings in Svelte 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
This has been updated from ComponentType here https://svelte.dev/docs/svelte/typescript#The-Component-type
See sveltejs/svelte#11775 for additional background
This is basically adjustment of #315