Skip to content

[MOB-11503] Fix eslint errors on vanilla JS sample app #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 28, 2025
Merged

Conversation

pauljung14
Copy link
Contributor

@pauljung14 pauljung14 commented May 28, 2025

JIRA Ticket(s) if any

Description

  • Fixes these linter errors
[eslint] 
/Users/paul.jung/dev/iterable-web-sdk/example/src/index.ts
   2:1   error  'axios' should be listed in the project's dependencies. Run 'npm i -S axios' to add it                 import/no-extraneous-dependencies
  10:8   error  Unable to resolve path to module '@iterable/web-sdk'                                                   import/no-unresolved
  16:46  error  Unexpected block statement surrounding arrow body; move the returned value immediately after the `=>`  arrow-body-style
  31:34  error  Unexpected block statement surrounding arrow body; move the returned value immediately after the `=>`  arrow-body-style
  53:32  error  ["ExternalNewTab"] is better written in dot notation                                                   dot-notation
  63:31  error  ["Deferred"] is better written in dot notation                                                         dot-notation
  • Also adds support for using env variables for login email and jwt generator url.

Test Steps

@pauljung14 pauljung14 requested a review from mprew97 as a code owner May 28, 2025 17:23
@codecov-commenter
Copy link

codecov-commenter commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.85%. Comparing base (8a4c1c0) to head (87455ef).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   64.85%   64.85%           
=======================================
  Files          47       47           
  Lines        1787     1787           
  Branches      567      567           
=======================================
  Hits         1159     1159           
+ Misses        627      588   -39     
- Partials        1       40   +39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pauljung14 pauljung14 merged commit 0ba7a70 into main May 28, 2025
1 check passed
@pauljung14 pauljung14 deleted the MOB-11503 branch May 28, 2025 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants