[MOB-11551] creates IterableEmbeddedMessageElements class #656

evantk91 · 2025-06-09T18:16:30Z

🔹 JIRA Ticket(s) if any

MOB-11551

✏️ Description

This pull request creates the IterableEmbeddedMessageElements class.

github-actions · 2025-06-09T18:16:57Z

Lines	Statements	Branches	Functions
	43.73% (227/519)	19.07% (37/194)	37.64% (64/170)

codeclimate · 2025-06-09T18:18:20Z

❌ 7 blocking issues (10 total)

Tool	Category	Rule	Count
eslint	Lint	Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
6	❌
eslint	Lint	'text' is already declared in the upper scope on line 74 column 11.	1	❌
qlty	Duplication	Found 54 lines of similar code in 2 locations (mass = 93)	2
qlty	Structure	Function with many parameters (count = 7): constructor	1

_{This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.}

src/embedded/classes/IterableEmbeddedMessageDefaultAction.ts

src/embedded/classes/IterableEmbeddedMessageElements.ts

src/embedded/classes/IterableEmbeddedMessageText.ts

lposen · 2025-06-09T21:10:45Z

src/embedded/classes/IterableEmbeddedMessageText.ts

+/**
+ * IterableEmbeddedMessageText represents a text element in an embedded message.
+ */
+export class IterableEmbeddedMessageText {


I feel like a lot of these don't necessarily need to be classes, and that they could just be interfaces. But I'll have to double check how they all fit together.

lposen

Please update the comments

…le-embedded-message-elements-class

codeclimate · 2025-06-24T20:50:50Z

src/__tests__/IterableEmbeddedMessageDefaultAction.test.ts

@@ -0,0 +1,40 @@
+import { IterableEmbeddedMessageDefaultAction } from '../embedded/classes/IterableEmbeddedMessageDefaultAction';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-24T20:50:51Z

src/__tests__/IterableEmbeddedMessageElements.test.ts

@@ -0,0 +1,214 @@
+import { IterableEmbeddedMessageElements } from '../embedded/classes/IterableEmbeddedMessageElements';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-24T20:50:51Z

src/__tests__/IterableEmbeddedMessageText.test.ts

@@ -0,0 +1,38 @@
+import { IterableEmbeddedMessageText } from '../embedded/classes/IterableEmbeddedMessageText';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-24T20:50:51Z

src/embedded/classes/IterableEmbeddedMessageDefaultAction.ts

@@ -0,0 +1,51 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-24T20:50:51Z

src/embedded/classes/IterableEmbeddedMessageDefaultAction.ts

+export class IterableEmbeddedMessageDefaultAction {
+  /**
+   * The type of iterable action
+   * For custom actions, the type is `action://` prefix followed by a custom action name
+   */
+  readonly type: string;
+
+  /**
+   * The url for the action when the type is `openUrl`
+   * For custom actions, data is empty
+   */
+  readonly data?: string;
+
+  /**
+   * Creates an instance of `IterableEmbeddedMessageDefaultAction`.
+   *
+   * @param type - The type of iterable action
+   * @param data - The url for the action when the type is `openUrl`
+   */
+  constructor(type: string, data?: string) {
+    this.type = type;
+    this.data = data;
+  }
+
+  /**
+   * Creates an instance of `IterableEmbeddedMessageDefaultAction` from a dictionary object.
+   *
+   * @param dict - The dictionary object containing the properties to initialize the `IterableEmbeddedMessageDefaultAction` instance.
+   * @returns A new instance of `IterableEmbeddedMessageDefaultAction` initialized with the provided dictionary properties.
+   */
+  static fromDict(
+    dict: Partial<EmbeddedMessageDefaultActionDict>
+  ): IterableEmbeddedMessageDefaultAction {
+    if (!dict.type) {
+      throw new Error('type is required');
+    }
+    return new IterableEmbeddedMessageDefaultAction(dict.type, dict.data);
+  }


Found 39 lines of similar code in 2 locations (mass = 76) [qlty:similar-code]

codeclimate · 2025-06-24T20:50:51Z

src/embedded/classes/IterableEmbeddedMessageElements.ts

@@ -0,0 +1,101 @@
+import { IterableEmbeddedMessageDefaultAction } from './IterableEmbeddedMessageDefaultAction';


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

codeclimate · 2025-06-24T20:50:51Z

src/embedded/classes/IterableEmbeddedMessageElements.ts

+  constructor(
+    title?: string,
+    body?: string,
+    mediaUrl?: string,
+    mediaUrlCaption?: string,
+    defaultAction?: IterableEmbeddedMessageDefaultAction,
+    buttons?: IterableEmbeddedMessageElementsButton[],
+    text?: IterableEmbeddedMessageText[]


Function with many parameters (count = 7): constructor [qlty:function-parameters]

codeclimate · 2025-06-24T20:50:51Z

src/embedded/classes/IterableEmbeddedMessageElements.ts

+      IterableEmbeddedMessageElementsButton.fromDict(button)
+    );
+
+    const text = dict.text?.map((text) =>


'text' is already declared in the upper scope on line 74 column 11. [eslint:@typescript-eslint/no-shadow]

codeclimate · 2025-06-24T20:50:51Z

src/embedded/classes/IterableEmbeddedMessageText.ts

@@ -0,0 +1,48 @@
+/**


Error loading TSDoc config file:
Error encountered for /home/runner/work/react-native-sdk/tsdoc.json:
Unable to resolve "extends" reference to "typedoc/tsdoc.json": Cannot find module 'typedoc/tsdoc.json' from '/home/runner/work/react-native-sdk'
[eslint:tsdoc/syntax]

Evan Greer added 2 commits June 9, 2025 12:11

feat: adds elements class and associated classes

57f48a3

feat: adds unit tests

a3397a4

evantk91 changed the title ~~[MOB-11551] iterable embedded message elements class~~ [MOB-11551] creates IterableEmbeddedMessageElements class Jun 9, 2025

lposen reviewed Jun 9, 2025

View reviewed changes

src/embedded/classes/IterableEmbeddedMessageDefaultAction.ts Show resolved Hide resolved

lposen reviewed Jun 9, 2025

View reviewed changes

src/embedded/classes/IterableEmbeddedMessageElements.ts Show resolved Hide resolved

lposen reviewed Jun 9, 2025

View reviewed changes

src/embedded/classes/IterableEmbeddedMessageText.ts Show resolved Hide resolved

lposen reviewed Jun 9, 2025

View reviewed changes

Base automatically changed from evan/MOB-11550-iterable-embedded-message-button-class to evan/embedded-message-class June 24, 2025 19:22

Merge branch 'evan/embedded-message-class' into evan/MOB-11551-iterab…

a292556

…le-embedded-message-elements-class

codeclimate bot reviewed Jun 24, 2025

View reviewed changes

chore: adds comments to props

58fe64e

evantk91 merged commit 2b2899c into evan/embedded-message-class Jun 24, 2025
4 of 5 checks passed

evantk91 deleted the evan/MOB-11551-iterable-embedded-message-elements-class branch June 24, 2025 21:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[MOB-11551] creates IterableEmbeddedMessageElements class #656

[MOB-11551] creates IterableEmbeddedMessageElements class #656

Uh oh!

evantk91 commented Jun 9, 2025 •

edited by jira bot

Loading

Uh oh!

github-actions bot commented Jun 9, 2025 •

edited

Loading

Uh oh!

codeclimate bot commented Jun 9, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lposen Jun 9, 2025

Uh oh!

lposen left a comment

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

codeclimate bot Jun 24, 2025

Uh oh!

Uh oh!

Uh oh!

		@@ -0,0 +1,40 @@
		import { IterableEmbeddedMessageDefaultAction } from '../embedded/classes/IterableEmbeddedMessageDefaultAction';

		@@ -0,0 +1,214 @@
		import { IterableEmbeddedMessageElements } from '../embedded/classes/IterableEmbeddedMessageElements';

		@@ -0,0 +1,38 @@
		import { IterableEmbeddedMessageText } from '../embedded/classes/IterableEmbeddedMessageText';

		@@ -0,0 +1,101 @@
		import { IterableEmbeddedMessageDefaultAction } from './IterableEmbeddedMessageDefaultAction';

[MOB-11551] creates IterableEmbeddedMessageElements class #656

[MOB-11551] creates IterableEmbeddedMessageElements class #656

Uh oh!

Conversation

evantk91 commented Jun 9, 2025 • edited by jira bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔹 JIRA Ticket(s) if any

✏️ Description

Uh oh!

github-actions bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codeclimate bot commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❌ 7 blocking issues (10 total)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lposen Jun 9, 2025

Choose a reason for hiding this comment

Uh oh!

lposen left a comment

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

codeclimate bot Jun 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

evantk91 commented Jun 9, 2025 •

edited by jira bot

Loading

github-actions bot commented Jun 9, 2025 •

edited

Loading

codeclimate bot commented Jun 9, 2025 •

edited

Loading