fix(server): resolve race condition in authentication wait mechanism #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a critical race condition in Authenticated::wait() where notifications could be lost if auth.set() was called between checking is_authenticated and calling notify.notified().await, causing permanent blocking of request handlers. Changes: - Create notified future before double-checking auth status to ensure no notifications are missed - Add is_authenticated() helper method for non-blocking authentication checks - Optimize auth.wait() call sites with fast-path checks to skip select! when already authenticated - Apply optimization to uni stream, bi stream, and datagram handlers The fix leverages Tokio's guarantee that Notify::notified() futures created before notify_waiters() will resolve immediately, preventing notification
Owner
|
I thought about it when I wrote those code, it should hard to occur... |
Owner
|
I'm wondering if there's some kind of test that can cover this race condition |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a critical race condition in Authenticated::wait() where notifications
could be lost if auth.set() was called between checking is_authenticated and
calling notify.notified().await, causing permanent blocking of request handlers.
Changes:
The fix leverages Tokio's guarantee that Notify::notified() futures created
before notify_waiters() will resolve immediately, preventing notification