Add support for rp2350 and dynamic flash sizing. Update to modern SDK. #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JZimnol
requested changes
Apr 12, 2025
Comment on lines
+26
to
+30
| #if PICO_PLATFORM == rp2350-arm-s | ||
| #include <RP2350.h> | ||
| #else | ||
| #include <RP2040.h> | ||
| #endif |
There was a problem hiding this comment.
You can't do such comparison on preprocesor macro. Even if PICO_PLATFORM is equal to "rp2040", the #if PICO_PLATFORM == rp2350-arm-s will be evaluated to true and the build will fail.
You should use some other preprocesor constants or create compile-time definitions like PICO_PLATFORM_RP2040 in CMakeLists.txt file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the project to the current version of the SDK. It adds support for rp2350 and uses the flash size as set by the SDKs board file.