Look up fulltext documents does not link existing PDFs

[stefan-kolb]

It looks like the autolink functionality does not work as expected anymore:

1. I already have a file starting with the correct BibTeX key in my PDF repo
2. It still downloads the file from the web

I expect to pick up the file from the PDF repo instead.

[stefan-kolb]

Instead I get this icon in the file tab:

When I hover it says it found the PDF and if I want to accept it.
However, this is

• hardly recognizable
• it still downloads the new PDF in the background

This is a little bit akward.

[stefan-kolb]

I guess if we find a matching paper we can just add it without further user confirmation, as it is configured like that in the preferences.
@tobiasdiez I guess you implemented that, maybe you can help?

[tobiasdiez]

Yes, I implemented that automatically found files are displayed in the entry editor. The display is indeed a bit irritating and we should improve it (tracked in #3607).

I don't understand why "auto-link" should download PDF's at all. We have a different button/menu entry for fulltext download, this should suffice.

[stefan-kolb]

Ah sorry, I mean Quality - Look up fulltext documents. The former behavior was:

• PDF already found link it instead of download it a new.

[tobiasdiez]

Ok, I can't remember I changed anything there but I do like the new behavior better and find it logical. If I click on "Look up fulltext document" I expect that JabRef downloads the fulltext for me regardless of whether there are already files linked or not.

[stefan-kolb]

Hm, well we could leave it in such a way but then downloa full text would be more appropriate than lookup.
Also, it means two steps for the users. Try to autolink files, iff not found download files.
Formerly, this was integrated in one step.

[Siedlerchr]

+1 for Looking up Fulldocuments should first try to search autolink file.
If not found -> Download from web

[stefan-kolb]

This is important as a user cannot know if a file already exists in some subfolder for example and then downloads it again.

[koppor]

Just a wild guess: It could be #3368 (not reviewed by me) and the follow-up fix #3509 (think, slightly reviewed by me).