Get snapcraft build approved

[LyzardKing]

Can somebody add the snapcraft secrets to the admin repo for the github actions?
Then we can uncomment the line in the build script and push the jabref snap to the store

as described here: https://forum.snapcraft.io/t/building-and-pushing-snap-packages-from-gitlab/9537
The tldr is:
snapcraft login
snapcraft export-login snapcraft.login
base64 snapcraft.login | xsel --clipboard

paste to the SNAPCRAFT_LOGIN_FILE in secrets

[LyzardKing]

I wonder if (to simplify things) the snap should not be built in the github actions after all..
it seems to complicate things, and it might instead just automatically trigger (build.snapcraft can do that) once the url for the latest build.jabref file is updated.
To enable this it would have to live in a separate repo (under the jabref organization, like JabRef/jabref-snap)
So without having to change the url a succesful build upstream would trigger a snapcraft build...without the docker addition..
@koppor @tobiasdiez what do you think?

[koppor]

This refs #5379.

[koppor]

I think, we should stick building it here. That way, we can ship daily builds. - Otherweise, we had to change our built files. Refs #5399

[LyzardKing]

It would ship daily builds anyway, ending up in the --edge channel.
But there would only ever be one daily build available.
That's the tradeoff..
A simple and automated build system, with 4 levels of "available" images: edge (continuously built, beta, candidate and stable).
Anyway, I think the snap is coming along nicely, with the new browser integration :)

[tobiasdiez]

I'm also in favor of build it here on github. This way we are more flexible (what triggers a build or prepare files before building). Moreover, we have everything in one place and treat different app stores in a similar way. As building the snap is working now, I also don't see any advantages in using build.snapcraft.io.

Mr @koppor just needs to login in snapcraft and provide github with the necessary secrets ;-)

[LyzardKing]

Building on builds.jabref is good.
It works and you can build different branches easily.
Just as a note, #5399 is not an issue with snapcraft, since it would refresh from master even if the name/version are the same.
In the previous snap the version was always set to 5.0.0-dev

[koppor]

I followed #5379 (comment) and provided SNAPCRAFT_LOGIN_FILE as secret in this repository.

[koppor]

Build upload activated at fd2d32b in the master branch. Added || true to allow failures of this step.

[LyzardKing]

Great! Now let's see if it builds.. I noticed in the script the other day it was set to push to beta...did we set it to edge?
(I'm not on my computer now..)

It should say push --release=edge for the daily build

jabref/.github/workflows/deployment.yml

Line 92 in fd2d32b

cd build/distribution/ && mdkir .snapcraft && echo ${SNAPCRAFT_LOGIN_FILE} | base64 --decode --ignore-garbage > .snapcraft/snapcraft.cfg && snapcraft push --release=beta *.snap || true

[tobiasdiez]

Done: 372c3ec