Deb file does not create launcher and shows wrong license info

[Siedlerchr]

I recently tested the deb files in my Ubuntu VM.
When opening the deb with Ubuntu Software center it shows that the license is proprietary and it does not generate a launcher for the install in /opt/

The jpackage supports various arguments for setting the launcher:
https://openjdk.java.net/jeps/343

[tobiasdiez]

Should be --linux-shortcut. The other options should also be investigated (e.g. deb-maintainer for email and file-associations)

[LyzardKing]

the deb doesn't have an explicit license setting, right?
the launcher is just a boolean, without a path, so in both the deb and rpm it'll take care of that.
Should these option go in the gradle under https://github.com/JabRef/jabref/blob/master/build.gradle#L590?
I can try having a go at this, building the deb locally, then try uploading on a PR/branch

[LyzardKing]

Can I build locally only the deb?

[tobiasdiez]

Yes, thats the right location for these arguments. You can build the deb locally: gradle jpackage. You need the jdk14 from https://jdk.java.net/jpackage/ and set the BADASS_JLINK_JPACKAGE_HOME environment variable to this path.

[LyzardKing]

If I build locally I get this error:
Error: Invalid or unsupported package type: [rpm]
Can I not build only the deb?

[Siedlerchr]

Try setting the installerType variable to "deb" in the jlink/jpackage config

[LyzardKing]

It builds, but the jpackage options are very limited.
It can create the desktop, but it still needs to be copied over in the postinst script (like the python script)
Or (I'm trying now) the desktop file can be added to the buildres/linux folder (and postinst script)
The main issue is that there is no way in jpackage to add mimetypes, keywords for example..
so instead of (used in the snap):

[Desktop Entry]
Name=JabRef
GenericName=BibTeX Editor
Comment=JabRef is an open source bibliography reference manager. The native file format used by JabRef is BibTeX, the standard LaTeX bibliography format.
Type=Application
Terminal=false
Icon=/opt/jabref/lib/JabRef.png
Exec=/opt/jabref/bin/JabRef %U
Keywords=bibtex;biblatex;latex;bibliography
Categories=Office;
StartupWMClass=org-jabref-JabRefMain
MimeType=text/x-bibtex;

We can have

[Desktop Entry]
Name=JabRef
Comment=JabRef
Exec=/opt/jabref/bin/JabRef
Icon=/opt/jabref/lib/JabRef.png
Terminal=false
Type=Application
Categories=Office
MimeType=

I personally think it's better to create it once, and use that. But if there are different opinions please let me know