Skip to content

Add gtk3 support #5302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Add gtk3 support #5302

merged 1 commit into from
Sep 10, 2019

Conversation

LyzardKing
Copy link
Collaborator

This is a WIP to solve #5298


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

@LyzardKing
Copy link
Collaborator Author

@Siedlerchr Do I have to change something in the build system?

@Siedlerchr
Copy link
Member

Well, gradle is still used for compiling and building. I am unfortunately not sure how and if this jlink stuff is needed for running

@Siedlerchr Siedlerchr merged commit 18cf80f into JabRef:master Sep 10, 2019
@LyzardKing
Copy link
Collaborator Author

Could we loop @tobiasdiez in this work?
Is there any difference in the build/run of the linux builds?

@Siedlerchr
Copy link
Member

Failed to generate snap metadata: The specified command 'desktop-launch' defined in the app 'jabref' does not exist or is not executable.
Ensure that 'desktop-launch' is installed with the correct path.

https://build.snapcraft.io/user/JabRef/jabref/670638

@LyzardKing
Copy link
Collaborator Author

I'll try and run the exact build (in lxd) like the server did.

@tobiasdiez
Copy link
Member

I have no experience, with snapcraft so I cannot say much about that. For the build, it should look as follows:

  • Run gradle jlink. This gives you a build/image folder containing a working runtime image (JabRef + all dependencies including the necessary java libraries).
  • In image/bin, you find some (platform-dependent) luncher scripts (on Windows: JabRef.bat).

So the snapcraft build should bundle the image folder together (or directly use the zip created by gradle jlinkzip) and invoke the correct lunch script (or replicate what they contain).

@LyzardKing
Copy link
Collaborator Author

Thanks! I'll try a few changes now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants