Add get_line confusable to Stdin::read_line()#1
Conversation
|
Thank you for doing this. |
|
You opened the PR in the wrong repository, you should do it here instead. Also I think a test case should be added in |
|
@GrigorenkoPV Yea, I didn't do it to the rust repository yet because I was still adding tests 😄 I've never added one of these tests, the strategy seems straight forward, but I don't know how to determine that error code that's in the comments. (i.e. //~ERROR E0599) Edit: Actually, after running So I've added: let mut buffer = String::new();
let stdin = std::io::stdin();
stdin.get_line(&mut buffer).unwrap(); //~ ERROR E0599
//~^ HELP you might have meant to use `read_line`I've run Edit (again): I see, my expected output was incorrect.. about to modify PR to target main repository. |
Add `get_line` confusable to `Stdin::read_line()` This pull request resolves rust-lang#131091 --- I've updated tests for `tests/ui/attributes/rustc_confusables_std_cases` in order to verify this change is working as intended. Before I submitted this pull request, I had a pull request to my local fork. If you're interested in seeing the conversation on that PR, go to JakenHerman#1. --- **Testing**: Run `./x.py test tests/ui/attributes/rustc_confusables_std_cases.rs`
Rollup merge of rust-lang#131163 - JakenHerman:master, r=Nadrieril Add `get_line` confusable to `Stdin::read_line()` This pull request resolves rust-lang#131091 --- I've updated tests for `tests/ui/attributes/rustc_confusables_std_cases` in order to verify this change is working as intended. Before I submitted this pull request, I had a pull request to my local fork. If you're interested in seeing the conversation on that PR, go to JakenHerman#1. --- **Testing**: Run `./x.py test tests/ui/attributes/rustc_confusables_std_cases.rs`
This pull request resolves rust-lang#131091
I've updated tests for
tests/ui/attributes/rustc_confusables_std_casesin order to verify this change is working as intended.