fix: do not convert functions where first parameter is this#64
Merged
Conversation
…ith-this-argument Prevent converting functions that declare this parameters
JamieMason
changed the title
thisthis
Owner
|
Released in 3.9.1, thanks a lot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (What)
Fixes #63 by preventing conversion of functions when the first parameter is
thisJustification (Why)
Some custom userland functions that are ultimately passed back into a library are sometimes required to be instance methods with
thisdeclared for correct argument types, regardless of whetherthisis needed by the function body. One such example is fastify'sapp.setErrorHandler(fn)(5.1.0)How Can This Be Tested?
Tests were added