Skip to content

Conversation

@alpha-tango-kilo
Copy link
Contributor

@alpha-tango-kilo alpha-tango-kilo commented May 19, 2024

Resolves #357

Synopsis

Generated documentation is incorrect, see issue

Solution

Ensure stringify! happens after quote! interpolation

Checklist

  • Documentation is updated (if required)
  • Tests are added/updated (if required)
  • CHANGELOG entry is added (if required)

Something for consideration: https://matklad.github.io/2022/10/24/actions-permissions.html

@alpha-tango-kilo alpha-tango-kilo force-pushed the is-variant-documentation branch from 6b7ea1e to ef12b71 Compare May 19, 2024 11:57
Copy link
Owner

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix. This was quite a silly bug. I don't think it's needed to add tests for this (seems hard to do for little gain).

@JelteF JelteF merged commit f5a9199 into JelteF:master May 25, 2024
@alpha-tango-kilo alpha-tango-kilo deleted the is-variant-documentation branch May 25, 2024 11:05
@tyranron tyranron added the k::documentation Related to project documentation label May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

k::documentation Related to project documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IsVariant fails to interpolate variant names in documentation

3 participants