Pass functions, not flows, in PlatformTextInputMethodRequest
#2122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
commented
May 15, 2025
Comment on lines
+387
to
+397
| coroutineScope { | ||
| // Currently TextInputService is used for keyboard show/hide actions and for | ||
| // backward compatibility by the LocalTextInputService. | ||
| // startInput and stopInput calls are required to properly configure the service | ||
| // and allow it to pass keyboard show/hide calls to the PlatformTextInputService. | ||
| launch(start = CoroutineStart.UNDISPATCHED) { | ||
| suspendCancellableCoroutine<Nothing> { | ||
| textInputService.startInput() | ||
| it.invokeOnCancellation { | ||
| textInputService.stopInput() | ||
| } |
There was a problem hiding this comment.
@ASalavei Please note the changes here. Hopefully I didn't break anything. The changes are because IDEA was complaining about the implicit Nothing and ambiguous coroutine context.
m-sasha
force-pushed
the
m-sasha/PlatformTextInputMethodRequest-functions
branch
6 times, most recently
from
0349ba5 to
4d4df5f
Compare
m-sasha
force-pushed
the
m-sasha/PlatformTextInputMethodRequest-functions
branch
from
4d4df5f to
746fba1
Compare
eymar
approved these changes
May 20, 2025
mazunin-v-jb
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to pass functions, rather than snapshot flows, in
PlatformTextInputMethodRequest. This is needed to fix https://youtrack.jetbrains.com/issue/CMP-8177/IME-popup-appears-at-wrong-horizontal-position which is caused by the collection of the snapshot flow happening too late (after the system has requested the "focused rect").Additionally, I've removed the
PlatformTextInputService2interface, as it doesn't appear to be needed. Its implementation,DesktopTextInputService2is never passed outside of platform-specific code.I've also removed
PlatformTextInputMethodRequest.outputValue, per discussion with @mazunin-v-jb, as it seemsvaluecan be used instead.Fixes https://youtrack.jetbrains.com/issue/CMP-8177/IME-popup-appears-at-wrong-horizontal-position
Testing
Tested manually to make sure the IME popup appears at the same position as with Swing text fields.
Release Notes
Fixes - Desktop