Support focus change with VoiceOver #2217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svastven
reviewed
Jul 4, 2025
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/Accessibility.uikit.kt
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/Accessibility.uikit.kt
Show resolved
Hide resolved
svastven
reviewed
Jul 4, 2025
|
|
||
| if (forceFocusedElementKey != focusedElementKey) { | ||
| forceFocusedElementKey = focusedElementKey | ||
| focusedElementKey?.let { |
There was a problem hiding this comment.
if there is no focused elemet (focusedElementKey == null) don't we want to set the focuseMode to None here?
There was a problem hiding this comment.
No, we should keep the old value. The reason is that Compose Ficus and Accessibility focus are work in parallel.
forceFocusedElementKey represent focused element of the Compose, but focuseMode represent the focus of Accessibility (at least it tries).
The logic is the following: when Compose focuses some node, we have to move Accessibility focus to this place. If compose releases focus, we don't need to do anything and keep focus as it was before.
svastven
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the accessibility focus to the most recently focused element.
Due to the complexity of implementation, it does not refocus on the same accessibility element that was already in focus. (Same behavior present on native iOS).
Fixes https://youtrack.jetbrains.com/issue/CMP-8272/Focus-change-with-VoiceOver-on-iOS-not-working
Release Notes
Fixes - iOS