When the user moves the caret during a composition, commit the composition #2255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-sasha
force-pushed
the
m-sasha/commit-composition-on-unexpected-caret-movement
branch
from
ece5b64 to
6f37fe7
Compare
igordmn
reviewed
Jul 18, 2025
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputService2.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputService2.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputService2.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputService2.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/desktopMain/kotlin/androidx/compose/ui/platform/DesktopTextInputService2.kt
Outdated
Show resolved
Hide resolved
m-sasha
force-pushed
the
m-sasha/commit-composition-on-unexpected-caret-movement
branch
from
6f37fe7 to
41abdd8
Compare
igordmn
approved these changes
Jul 21, 2025
m-sasha
deleted the
m-sasha/commit-composition-on-unexpected-caret-movement
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user moves the caret during a composition, e.g. by clicking somewhere, commit the composition immediately.
Fixes https://youtrack.jetbrains.com/issue/CMP-8200
Testing
Tested manually.
Unfortunately it's not possible to create a unit test because the fix implies bidirectional interaction with the
InputContext.This should be tested by QA
Release Notes
Fixes - Desktop