Skip to content

Conversation

m-sasha
Copy link
Member

@m-sasha m-sasha commented Jun 10, 2025

Currently, gradle sync fails on macOS if TargetFormat.AppImage is present in targetFormats.
Note that this PR removes the check entirely, as the list of target formats should not be validated at gradle sync.
There is no corresponding check for e.g. TargetFormat.Dmg on Windows.

Testing

No testing needed.

Release Notes

Fixes - Gradle Plugin

  • Don't fail gradle sync if TargetFormat.AppImage is specified in targetFormats on macOS.

@m-sasha m-sasha requested a review from igordmn June 10, 2025 17:27
@m-sasha
Copy link
Member Author

m-sasha commented Jun 10, 2025

@terrakok Can you look and say why this fails?

The failures are:

ResourcesTest > cocoapodsIosXCFrameworkResources(kotlin=2.2.0-Beta1, gradle=8.7, agp=8.6.0) FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure at ResourcesTest.kt:876

and

ResourcesTest > xcframeworkResources(kotlin=2.2.0-Beta1, gradle=8.7, agp=8.6.0) FAILED
    org.gradle.testkit.runner.UnexpectedBuildFailure at ResourcesTest.kt:762

@terrakok
Copy link
Member

Try to rebase on the fresh master.

Cause 1: org.gradle.internal.resolve.ModuleVersionNotFoundException: Could not find org.jetbrains.kotlin:compose-compiler-gradle-plugin:2.2.0-Beta2-1

the version was deleted because it is a temporary dev build. I already updated the version in #5330

@m-sasha m-sasha force-pushed the m-sasha/dont-fail-gradle-sync-on-AppImage-target branch from ad932ce to 0dd6e5a Compare June 11, 2025 08:35
@m-sasha
Copy link
Member Author

m-sasha commented Jun 11, 2025

Try to rebase on the fresh master.

Done, thanks.

@m-sasha
Copy link
Member Author

m-sasha commented Jun 11, 2025

@terrakok Now it's failing at

ResourcesTest > testFinalArtefacts(kotlin=2.2.0-Beta1, gradle=8.13, agp=8.9.0) FAILED
    java.io.IOException at ForEachOps.java:183

@terrakok
Copy link
Member

ignore it. this is a known JVM CI problem

@m-sasha m-sasha merged commit cf0ff4f into master Jun 11, 2025
23 of 25 checks passed
@m-sasha m-sasha deleted the m-sasha/dont-fail-gradle-sync-on-AppImage-target branch June 11, 2025 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants