Skip to content

Update the Dart parser to allow triple-shift operators, and triple-shifts as a valid shift operator. #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Update the Dart parser to allow triple-shift operators, and triple-shifts as a valid shift operator. #792

wants to merge 3 commits into from

Conversation

jwren
Copy link
Contributor

@jwren jwren commented Feb 18, 2021

The first of up to 3 parser changes: dart-lang/sdk#44918

@jwren
Copy link
Contributor Author

jwren commented Feb 18, 2021

@alexander-doroshko

@alexander-doroshko
Copy link
Contributor

Thanks! LGTM.

Could you add a test (DartParsingTest)? Updating an existing file would be enough (say, Operators.dart). Having something like <List<List<List>>> in a test would be great - to make sure parser can distinguish generics vs operator. Symbol literal (#>>>) is also a good case for parsing test.

Also, I guess, new operator should be added to a couple of token sets in DartTokenTypesSets.

@jwren
Copy link
Contributor Author

jwren commented Feb 19, 2021

@alexander-doroshko PTAL, from my commit: Add >>> tests into DartParsingTest, and updated DartTokenTypesSets to include >>>, note that I also added >> where it was missing.

@alexander-doroshko
Copy link
Contributor

Great! Thanks, merged.

@SergeyZh SergeyZh closed this in 9b28c36 Feb 19, 2021
@jwren jwren mentioned this pull request Feb 22, 2021
Closed
SergeyZh pushed a commit that referenced this pull request Feb 26, 2021
@jwren @intellij-monorepo-bot
Dart: support triple-shift operator
7031158 
close #792

(cherry picked from commit 711f6a1a06120c1c5e076af9691944b21d4ad90a)

IJ-CR-6364

GitOrigin-RevId: 6a9571b3b61463ab804983a4847376653ab03f80
SergeyZh pushed a commit that referenced this pull request Feb 26, 2021
@jwren @intellij-monorepo-bot
Dart: support triple-shift operator
f255359 
close #792

(cherry picked from commit 711f6a1a06120c1c5e076af9691944b21d4ad90a)

IJ-CR-6364

GitOrigin-RevId: 32efa9c01b2071850a14cf63bbe5d77a86d154c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexander-doroshko alexander-doroshko

Labels
Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwren @alexander-doroshko