Enhanced Enum support in the Dart.bnf parser for Dart 2.17 #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| enumConstantDeclaration ::= componentName | ||
| enumConstantDeclaration ::= metadata* componentName typeArguments? arguments? | | ||
| metadata* componentName typeArguments? '.' componentName arguments |
There was a problem hiding this comment.
Any input matches arguments?, and this means that the second branch of this rule (after |) will never be reached. To make it work as expected, I flipped the branches. Test updated as well.
enumConstantDeclaration ::= metadata* componentName typeArguments? '.' componentName arguments |
metadata* componentName typeArguments? arguments?
| { | ||
| mixin="com.jetbrains.lang.dart.psi.impl.AbstractDartComponentImpl" | ||
| implements="com.jetbrains.lang.dart.psi.DartComponent" | ||
| methods = [getMetadataList] | ||
| methods= [getMetadataList] |
There was a problem hiding this comment.
With the updated grammar, we don't need custom getMetadataList() method declaration anymore (otherwize the generated code contains 2 of them and doesn't compile). But now we need custom getComponentName method declaration. Added it here and in DartPsiImplUtil, so now the generated code compiles fine.
|
Thanks, pushed. |
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
close #849 (cherry picked from commit 6ef1c112bf87d6e9a6803a0c36157178a6b6913e) (cherry picked from commit 93fc285ed9fa443195fca4fb4b8123a281183013) GitOrigin-RevId: 48efcf939b18d87b36703e4aa14d0de20cd903d4
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
close #849 (cherry picked from commit 6ef1c112bf87d6e9a6803a0c36157178a6b6913e) (cherry picked from commit 93fc285ed9fa443195fca4fb4b8123a281183013) (cherry picked from commit 48efcf939b18d87b36703e4aa14d0de20cd903d4) GitOrigin-RevId: 892def6b88031c0c5e40953dffffc1a47c226c9c
SergeyZh
pushed a commit
that referenced
this pull request
Mar 4, 2022
close #849 (cherry picked from commit 6ef1c112bf87d6e9a6803a0c36157178a6b6913e) GitOrigin-RevId: 93fc285ed9fa443195fca4fb4b8123a281183013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart-lang/sdk#47869