Skip to content

Conversation

@AndreiIurko
Copy link
Collaborator

In this pull request the following improvements to Azure Pipelines are suggested:

  1. Summary publishing in "Extensions" tab of job
  2. Support of "postComment" input variable: posting of comment in merge request and updating it if job is reran
  3. Support of quick-fixes: both branch and pull-request modes are supported, as well as prMode compatibility

Also, the refactoring was made to reuse Qodana Scan GHA code and constants where possible

@AndreiIurko AndreiIurko requested a review from tiulpin as a code owner February 5, 2025 10:43
@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Qodana for JVM

3 new problems were found

Inspection name Severity Problems
ESLint 🔴 Failure 2
Duplicated code fragment ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@tiulpin tiulpin requested a review from Copilot February 5, 2025 11:17
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 13 out of 27 changed files in this pull request and generated no comments.

Files not reviewed (14)
  • common/package.json: Language not supported
  • common/tsconfig.json: Language not supported
  • package.json: Language not supported
  • vsts/package.json: Language not supported
  • vsts/vss-extension.dev.json: Language not supported
  • common/tests/main.test.ts: Evaluated as low risk
  • common/jest.config.js: Evaluated as low risk
  • vsts/src/output.ts: Evaluated as low risk
  • common/utils.ts: Evaluated as low risk
  • scan/src/annotations.ts: Evaluated as low risk
  • scan/tests/main.test.ts: Evaluated as low risk
  • scan/src/output.ts: Evaluated as low risk
  • vsts/src/main.ts: Evaluated as low risk
  • scan/src/utils.ts: Evaluated as low risk
Comments suppressed due to low confidence (2)

vsts/tests/main.test.ts:23

  • [nitpick] The function name annotationsDefaultFixture is already defined in common/__tests__/main.test.ts. Consider renaming it to avoid confusion.
export function annotationsDefaultFixture(): ProblemDescriptor[] {

vsts/src/utils.ts:280

  • The console.log(result.stdout) statement seems unnecessary and could be removed to avoid cluttering the logs.
console.log(result.stdout)

@AndreiIurko AndreiIurko force-pushed the iurko/azure-improvements branch 2 times, most recently from 748e0ca to a87f221 Compare February 5, 2025 15:16
@AndreiIurko AndreiIurko requested a review from hybloid February 5, 2025 15:19
@tiulpin
Copy link
Member

tiulpin commented Feb 6, 2025

Please use gitmoji as all the commits here are.

@AndreiIurko AndreiIurko force-pushed the iurko/azure-improvements branch from a87f221 to 56bde60 Compare February 10, 2025 09:33
@AndreiIurko AndreiIurko merged commit f006661 into main Feb 10, 2025
82 of 83 checks passed
@tiulpin tiulpin deleted the iurko/azure-improvements branch April 28, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants