Skip to content

Avoid suggesting C# 8 language features #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 31, 2019
Merged

Avoid suggesting C# 8 language features #1380

merged 15 commits into from
Oct 31, 2019

Conversation

van800
Copy link
Member

@van800 van800 commented Oct 28, 2019 •
edited
Loading

#1379

Use path to roslyn folder in Unity to determine LangVersion.

@van800 van800 self-assigned this Oct 28, 2019
@van800 van800 requested a review from citizenmatt October 30, 2019 10:09
@van800 van800 changed the title [WIP] Avoid suggesting C# 8 language features Avoid suggesting C# 8 language features Oct 30, 2019
@van800 van800 changed the base branch from net193 to net193-update-rd October 30, 2019 12:37
@van800 van800 changed the base branch from net193-update-rd to net193 October 30, 2019 12:37
citizenmatt
citizenmatt requested changes Oct 30, 2019
View reviewed changes
Copy link
Member

@citizenmatt citizenmatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@van800 van800 merged commit d1d083d into net193 Oct 31, 2019
@van800 van800 deleted the net193-langVersion branch October 31, 2019 12:11
@citizenmatt citizenmatt added this to the Rider 2019.3 milestone Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@citizenmatt citizenmatt citizenmatt requested changes

Assignees

@van800 van800

Labels
None yet
Projects
None yet
Milestone
Rider 2019.3
Development

Successfully merging this pull request may close these issues.
3 participants
@van800 @citizenmatt @krasnotsvetov