Perfomance analysis refactoring #1459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
citizenmatt
reviewed
Dec 13, 2019
resharper/resharper-unity/src/CSharp/Daemon/Errors/CSharpErrors.xml
Outdated
Show resolved
Hide resolved
citizenmatt
reviewed
Dec 13, 2019
resharper/resharper-unity/src/CSharp/Daemon/Errors/CSharpErrors.xml
Outdated
Show resolved
Hide resolved
citizenmatt
reviewed
Dec 13, 2019
...-unity/src/CSharp/Daemon/Stages/Analysis/MultidimensionalArraysDeclarationProblemAnalyzer.cs
Outdated
Show resolved
Hide resolved
citizenmatt
requested changes
Dec 13, 2019
There was a problem hiding this comment.
- The availability tests aren't showing the warning?
- This feels very much like a micro-optimisation - do we want to add a warning to every multidimensional array declaration, or should this just be for arrays that are accessed in performance critical context, with the access highlighted as expensive?
- We need more tests for higher ranks of multidimensional arrays. Probably also any other variation of initialisation or access - will it convert expressions, etc.
- We absolutely need a "Why is Rider suggesting this?" page for this one
| } | ||
|
|
||
| // Rare case, ignore it | ||
| if (multipleDeclaration == null || multipleDeclaration.Declarators.Count > 1) |
There was a problem hiding this comment.
Why is this a rare case? Does it include the example of int foo[1,3], bar[2,2]? Shouldn't that be handled too?
...-unity/src/CSharp/Daemon/Stages/Analysis/MultidimensionalArraysDeclarationProblemAnalyzer.cs
Outdated
Show resolved
Hide resolved
|
|
||
| // Don't know where we should insert array initialization (constructor?, which constructor if there are several constructors?) | ||
| if (usages.Count > 0 && element is IFieldDeclaration && arrayCreationExpression?.ArrayInitializer == null) | ||
| return; |
There was a problem hiding this comment.
Add the warning, but don't show the quick fix?
...nity/src/CSharp/Feature/Services/QuickFixes/InefficientMultidimensionalArrayUsageQuickFix.cs
Show resolved
Hide resolved
krasnotsvetov
changed the title
krasnotsvetov
changed the title
citizenmatt
reviewed
Jan 17, 2020
...sharper-unity/src/CSharp/Feature/Services/Explanatory/UnityCodeInspectionWikiDataProvider.cs
Show resolved
Hide resolved
...rper/resharper-unity/src/CSharp/Daemon/Stages/Highlightings/UnityHighlightingAttributeIds.cs
Show resolved
Hide resolved
...test/data/CSharp/Daemon/Stages/PerformanceCriticalCodeAnalysis/resharper/SimpleTest2.cs.gold
Show resolved
Hide resolved
...ity/test/data/CSharp/Daemon/Stages/PerformanceCriticalCodeAnalysis/rider/SimpleTest2.cs.gold
Show resolved
Hide resolved
citizenmatt
approved these changes
Jan 17, 2020
2. Rewrite current performance analyzer to new logic (remove seperate perfomance unity stage and move logic to common unity stage) 3. Do not mark method as expensive only if null comparison with unity object is used 4. Move mul order analysis to perfomance analysis 5. Improve and move multidim arrays usage analysis to perfomance analysis
2. Update tests/return ignored tests
krasnotsvetov
force-pushed
the
net201-vk-jagged-arrays
branch
from
890f5f0 to
080f9cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.