Skip to content

Unity version and app path should always be in sync #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 20, 2020

Conversation

van800
Copy link
Member

@van800 van800 commented Mar 16, 2020

Requirements:

  1. path and version used in StartUnity action should be in sync.
  2. We have multiple ways of guessing the path and version. Like reading ProjectVersion.txt, EditorInstance.json, inferring from path to Unity*.dll in csproj
  3. Inferring from path to Unity*.dll in csproj is good because it helps to handle any custom unpredictable location of Unity installation. But version in ProjectVersion.txt should be preferable.

@van800 van800 self-assigned this Mar 16, 2020
@van800 van800 changed the title unity version and app path should always be in sync [WIP] unity version and app path should always be in sync Mar 18, 2020
@van800 van800 changed the title [WIP] unity version and app path should always be in sync Unity version and app path should always be in sync Mar 20, 2020
@van800 van800 requested a review from krasnotsvetov March 20, 2020 12:56
@van800 van800 merged commit fcced4b into net201 Mar 20, 2020
@van800 van800 deleted the net201-sync-version-app-path branch March 20, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant