Skip to content

Avoid calling Refresh on every save in the editor #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2020
Merged

Avoid calling Refresh on every save in the editor #1629

merged 1 commit into from
Apr 21, 2020

Conversation

van800
Copy link
Member

@van800 van800 commented Apr 21, 2020 •
edited
Loading

Saves in the editor might be very frequent.
And each refresh may break completion https://youtrack.jetbrains.com/issue/RIDER-37420

From user logs:
image

@van800 van800 requested a review from krasnotsvetov April 21, 2020 09:25
@van800 van800 self-assigned this Apr 21, 2020
@van800
Copy link
Member Author

van800 commented Apr 21, 2020

reviewed by @krasnotsvetov

@van800 van800 merged commit 34bc664 into net201 Apr 21, 2020
@van800 van800 deleted the net201-less-refresh branch April 21, 2020 19:41
@citizenmatt citizenmatt added this to the Rider 2020.1.1 milestone Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krasnotsvetov krasnotsvetov Awaiting requested review from krasnotsvetov

Assignees

@van800 van800

Labels
None yet
Projects
None yet
Milestone
Rider 2020.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@van800 @citizenmatt